Skip to content

test: mv file to broken symlink file/dir #10739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hlsxx wants to merge 3 commits into
base: main
Choose a base branch
from
Open

test: mv file to broken symlink file/dir #10739

hlsxx wants to merge 3 commits into from
+30 −0

Conversation

@hlsxx
Copy link

@hlsxx hlsxx commented Feb 5, 2026 •
edited
Loading

Overview

This PR adds a test suite for the mv utility covering broken symlink scenarios.

The tests verify that moving a file onto a broken symlink behaves correctly, matching GNU mv behavior:

  • Broken symlink pointing to a file
  • Broken symlink pointing to a directory

Test Cases

Create a file and a broken symlink to a file:

touch file
ln -s missing-target broken
./coreutils mv file broken

@oech3
Copy link
Contributor

oech3 commented Feb 5, 2026 •
edited
Loading

Please disbale tests using symlinks on Windows too.

@hlsxx
Copy link
Author

hlsxx commented Feb 5, 2026

Sorry, I’m not sure what you mean — these tests already use #[cfg(all(unix, not(target_os = "android")))], so they are skipped on Windows.

@oech3
Copy link
Contributor

oech3 commented Feb 5, 2026

Sorry. I missed.

@hlsxx
Copy link
Author

hlsxx commented Feb 5, 2026

Never mind, anyway pipeline seems broken

@oech3
Copy link
Contributor

oech3 commented Feb 5, 2026

Do you think that https://github.com/uutils/coreutils/actions/runs/21716161484/job/62634024086?pr=10739#step:6:7599 is caused by filling disk space?

@github-actions
Copy link

github-actions bot commented Feb 6, 2026

GNU testsuite comparison:

GNU test failed: tests/tail/symlink. tests/tail/symlink is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/misc/usage_vs_getopt (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)

@github-actions
Copy link

github-actions bot commented Feb 7, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hlsxx @oech3 @sylvestre